http, async_hooks: remove unneeded reference to wrapping resource

Remove the reference from handle to the unique/wrapping resource ReusedHandle as there is meanwhile a strong reference for all async resources in place via AsyncWarp::resource_. PR-URL: #32054 Refs: #30959 Refs: #30196 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Apr 28, 2020 · 12b8345 · 12b8345
1 parent 16a913f
commit 12b8345
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -45,18 +45,10 @@ const kOnKeylog = Symbol('onkeylog');
 // ClientRequest.onSocket(). The Agent is now *strictly*
 // concerned with managing a connection pool.
 
-const kReusedHandle = Symbol('kReusedHandle');
 class ReusedHandle {
   constructor(type, handle) {
     this.type = type;
     this.handle = handle;
-    // We need keep the resource object alive from this object, because
-    // domains rely on GC of the resource object for lifetime tracking.
-    // TODO(addaleax): This should really apply to all uses of
-    // AsyncWrap::AsyncReset() when the resource is not the AsyncWrap object
-    // itself. However, HTTPClientAsyncResource and HTTPServerAsyncResource
-    // hold on to other objects, inhibiting GC.
-    handle[kReusedHandle] = this;
   }
 }