test: fix test-performance-measure

Refs: #42949 Looking at the documentation for setTimeout (https://nodejs.org/api/timers.html#settimeoutcallback-delay-args) there is no guarantee that setTimeout won't complete early. From the failure of #42949 this is likely what happened. I have updated the assert.ok test to allow some variation in the test. PR-URL: #44637 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Sep 16, 2022 · 0928897 · 0928897
1 parent 325f549
commit 0928897
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/test/parallel/test-performance-measure.js b/test/parallel/test-performance-measure.js
@@ -5,11 +5,12 @@ const assert = require('assert');
 
 const { PerformanceObserver, performance } = require('perf_hooks');
 const DELAY = 1000;
+const ALLOWED_MARGIN = 10;
 
 const expected = ['Start to Now', 'A to Now', 'A to B'];
 const obs = new PerformanceObserver(common.mustCall((items) => {
   items.getEntries().forEach(({ name, duration }) => {
-    assert.ok(duration > DELAY);
+    assert.ok(duration > (DELAY - ALLOWED_MARGIN));
     assert.strictEqual(expected.shift(), name);
   });
 }));