Skip to content

Commit

Permalink
deps: V8: cherry-pick 1e36e21acc40
Browse files Browse the repository at this point in the history
Original commit message:

    Remove unnecessary export, which happens to break MSVC DLL builds.

    Change-Id: I47c9211274cefd26bde6bd93aa7503e022df4357
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2042874
    Reviewed-by: Ulan Degenbaev <[email protected]>
    Commit-Queue: Bill Ticehurst <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#66179}

Refs: v8/v8@1e36e21

PR-URL: #32116
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
mmarchini committed Mar 18, 2020
1 parent 0220c29 commit 049160d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/heap/memory-measurement.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace internal {
class Heap;
class NativeContextStats;

class V8_EXPORT_PRIVATE MemoryMeasurement {
class MemoryMeasurement {
public:
explicit MemoryMeasurement(Isolate* isolate);

Expand Down

0 comments on commit 049160d

Please sign in to comment.