tools: enable backtrace when V8 is built for PPC and S390

Refs: #119
nodejs · Nov 6, 2019 · 359050c · 359050c
1 parent 3cfda19
commit 359050c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/common.gypi b/common.gypi
@@ -105,6 +105,9 @@
         'obj_dir%': '<(PRODUCT_DIR)/obj.target',
         'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a',
       }],
+      ['target_arch in ("ppc64", "s390x")', {
+        'v8_enable_backtrace': 1,
+      }],
     ],
   },
 

diff --git a/tools/make-v8.sh b/tools/make-v8.sh
@@ -23,7 +23,7 @@ if [[ "$ARCH" == "s390x" ]]; then
   ln -s $CXX_PATH "$BUILD_TOOLS/gcc"
   g++ --version
   export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config
-  gn gen -v out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x"'
+  gn gen -v out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true'
   ninja -v -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test
 elif [[ "$ARCH" == "ppc64le" ]]; then
   if [[ X"$CXX" != X ]]; then
@@ -32,7 +32,7 @@ elif [[ "$ARCH" == "ppc64le" ]]; then
   fi
   g++ --version
   export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config-files
-  gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64"'
+  gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64" v8_enable_backtrace=true'
   ninja -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test
 else
   PATH=~/_depot_tools:$PATH tools/dev/v8gen.py $BUILD_ARCH_TYPE --no-goma $V8_BUILD_OPTIONS