This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
url: resolve urls with . and .. #9427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes nodejs#8992.
|
@trevnorris @cjihrig After merging v0.10 into v0.12 and v0.12 in master, the revert of the original PR has landed into v0.12 and master. According to my comment a while ago, I suggest landing the original PR in master, which is why this PR is created against master. |
|
SGTM. |
|
Works for me too. LGTM |
misterdjules
pushed a commit
that referenced
this pull request
Mar 17, 2015
'.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes #8992. Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #9427
|
@amir-s @trevnorris @cjihrig Thank you! Finally landed for good in 9b534e2 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'.' and '..' are directory specs and resolving urls with or without the
hostname with '.' and '..' should add a trailing slash to the end of the
url.
Fixes #8992.