test: integrate v8 test suite #9208
Conversation
Make it possible to run the basic v8 test suite. To get started, include `--with-v8-tests` on `configure`. Running `make` will then build the test suite. ```bash ./configure --with-v8-tests make make test-v8 ``` If you include i18n when you build, you can run `make test-v8-int` ```bash ./configure --with-v8-tests --with-intl=full-icu make make test-v8-intl ``` Quick checks only. No presubmits. Release mode. The commit includes some patches to the v8 dependency. It seems that the .gitignore filters out some necessary log files and collator/default-locale appears to be working on macos 10.10.
|
Oh... one very important additional point: one of the tests (cctest) requires C++11 in order to compile. To build successfully on mac I had to set |
|
Nice work. /cc @tjfontaine @cjihrig |
|
+1 |
|
@misterdjules Know if this would change anything with Jenkins? |
431eb17 had integrated the addition of V8's version in V8's profiler log files, without backporting the test that was included in the original change (https://codereview.chromium.org/806143002). This commit backports this test. The newly added test was tested with nodejs#9208.
431eb17 had integrated the addition of V8's version in V8's profiler log files, without backporting the test that was included in the original change (https://codereview.chromium.org/806143002). This commit backports this test. The newly added test was tested with nodejs#9208.
431eb17 had integrated the addition of V8's version in V8's profiler log files, without backporting the test that was included in the original change (https://codereview.chromium.org/806143002). This commit backports this test. The newly added test was tested with nodejs#9208.
|
cc @joyent/node-coreteam ... where are we at with this? |
|
/cc @misterdjules |
|
@jasnell @trevnorris Please accept my apologies for the delay in my response. First, thank you very much James for this! I tried to run I had tested it before (around the time the PR was submitted), and it had worked well, so I'm not sure if I'm doing something wrong or if something changed on google's side in the meantime. Did you try to build it recently? Other than that, in my opinion it would be better to download gtest only if we want to run V8's tests. In other words, building the default target would not do anything different than what it does currently, and gtest would be donwloaded only when building I would also put the additional GYP configuration in a separate file and keep only what is needed to build the node binary in As for the requirement on C++11, do we know exactly what code needs what feature(s) of C++11? Thank you very much again! |
|
I can go back and tweak the build so that the test stuff is built only if There is one test class that fails without the C++11 stuff. It may be
|
|
Sounds good, thank you @jasnell! |
I would recommend against downloading stuff as part of a build step. I suggest just putting the tests in git. |
|
Replaced with #14185 |
Make it possible to run the basic v8 test suite.
To get started, include
--with-v8-testsonconfigure. Runningmakewill then build the test suite.If you include i18n when you build, you can run
make test-v8-intlQuick checks only. No presubmits. Release mode.
The commit includes some patches to the v8 dependency. It seems
that the .gitignore filters out some necessary log files and
intl/collator/default-locale appears to be working on macos 10.10.
/cc @misterdjules @tjfontaine - Please take a look and let me know if
this is a good approach..