This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
dns: propagate domain for c-ares methods #8732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var assert = require('assert'); | ||
| var cares = process.binding('cares_wrap'); | ||
|
|
||
| var dns = require('dns'); |
chrisdickinson
force-pushed
the
fix-cares-domains
branch
from
285e8bf
to
35a6d48
Compare
|
Seeing domain's further pollute our code base always makes my stomach turn. If it wasn't so bloody expensive to do this then I'd recommend we just place it in the But, this LGTM for now. :) |
chrisdickinson
added a commit
that referenced
this pull request
Nov 17, 2014
Fixes: #5471 PR-URL: #8732 Reviewed-by: Trevor Norris <[email protected]>
|
Merged in 0fef250. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #5471, domains were not being propagated for certain dns methods (those using
class Queryincares_wrap.cc). This rectifies the situation./cc @trevnorris