test: add test-spawn-cmd-named-pipe #7433
Conversation
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
|
This test requires libuv fix joyent/libuv#1223 in order to pass |
| function parent() { | ||
| var net = require('net'); | ||
| var spawn = require('child_process').spawn; | ||
| var assert = require('assert'); |
|
Minor style nits, otherwise looking good! |
|
Thanks @indutny , updated per your feedback. |
| }); | ||
| c.on('end', function() { | ||
| console.log('stdoutPipeServer disconnected'); | ||
| gotResponse = (buf.toString() == 'hello'); |
There was a problem hiding this comment.
I'd rather use .join('') instead of toString() here.
|
Looking good, one minor nit, and will land it as soon as we will do libuv update again |
See #7345 Adding a test to verify that a node process spawned via cmd with named pipes can access its stdio streams.
|
Updated to use push() and join() |
|
LGTM, let's land it after updating libuv. cc @tjfontaine |
|
It looks like this is failing as of latest v0.12. |
|
@orangemocha ... still needed? |
Per: nodejs/node-v0.x-archive#7433 Adding a test to verify that a node process spawned via cmd with named pipes can access its stdio streams.
|
Still valid. Will land shortly. |
See #7345 Adding a test to verify that a node process spawned via cmd with named pipes can access its stdio streams. PR-URL: #7433 Reviewed-By: Fedor Indutny <[email protected]>
|
Awesome... we'll want to make sure that the commits in master land over in nodejs/node master also |
See #7345
Adding a test to verify that a node process spawned via cmd with
named pipes can access its stdio streams.