build: add libicu i18n support

[bnoordhuis]

Adds a --with-icu-path= switch to the configure script. Requires that the user
checks out the copy of libicu that's bundled with chromium to a fixed directory.
It's still a little rough around the edges but it works.

Fixes #6371.

Suggested reviewers: @tjfontaine @trevnorris

[Nodejs-Jenkins]

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit bnoordhuis/node@fc081ff has the following error(s):

• Commit message line too long: 2
• Commit message line too long: 3

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

[bnoordhuis]

I'm considering rewording this to "With libicu i18n support (UNSUPPORTED):"

[trevnorris]

agreed.

[trevnorris]

+1 from me.

[tjfontaine]

LGTM, can we use a git example in the readme instead of svn?

[bnoordhuis]

can we use a git example in the readme instead of svn?

Not really. It only works with the libicu that's bundled with chromium. You can't do partial checkouts with git and the full chromium tree is a whopping 12 GB.

[trevnorris]

@davglass Could you try this patch and see if it fits your needs?

[davglass]

Ping @rohiniwork, can you check out this patch?

[rohiniwork]

This worked for me, except for the I had to run configure with the gyp path

./configure --with-icu-path=deps/v8/third_party/icu46/icu.gyp

This is because v8.gyp assumes the gyp file is specified, not just the directory
'<(icu_gyp_path):icui18n'

Thanks,
--rohini

[davglass]

Same here, I had to change the configure line like above. If we update the README with that bit I'd be happy that this is merged :)

[trevnorris]

This was merged in 9e32a7d