Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

build: Intl: bump ICU4C from 54 to 55 #25856

Closed
wants to merge 1 commit into from
Closed

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 13, 2015

Fixes: #25855
node was using ICU4C 54 ( released 2014-oct-06 )

Originally-Fixes: nodejs/node#2292
Original-PR-URL: nodejs/node#2293

@orangemocha @joaocgreis or anyone any comments on the rebase?

@jasnell
Copy link
Member

jasnell commented Aug 13, 2015

LGTM!

@joaocgreis
Copy link
Member

LGTM, but the PR-URL is corrupted. It can be simply removed, will be added by Jenkins and would get duplicated.

srl295 added a commit to srl295/node-v0.x-archive that referenced this pull request Aug 13, 2015
node was using ICU4C 54 ( released 2014-oct-06 )

* Bump to ICU4C 55 ( released 2015-apr-08)
 * Timezone fixes, translation fixes, bug/performance fixes.
 * Speed improvements in date formatting
 * ICU4C 55 changelog: http://site.icu-project.org/download/55
 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27

* Retarget the file exclusions from ICU4C 54 to ICU4C 55
 * (improves on-disk footprint on some platforms)

Fixes: nodejs#25855
PR-URL: nodejs#25856
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>

Backport from nodejs/node:
> Originally-Fixes: nodejs/node#2292
> Original-PR-URL: nodejs/node#2293
@srl295
Copy link
Member Author

srl295 commented Aug 13, 2015

@joaocgreis it's just a placeholder (hash snowman), I didn't have a PR # when it landed. I've fixed this in d9eedaf - sorry for the noise.

@joaocgreis
Copy link
Member

@srl295 Unless you plan to land this manually, only the Fixes: line is needed. Jenkins will add the PR-URL and Reviewed-By lines.

srl295 added a commit to srl295/node-v0.x-archive that referenced this pull request Aug 13, 2015
node was using ICU4C 54 ( released 2014-oct-06 )

* Bump to ICU4C 55 ( released 2015-apr-08)
 * Timezone fixes, translation fixes, bug/performance fixes.
 * Speed improvements in date formatting
 * ICU4C 55 changelog: http://site.icu-project.org/download/55
 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27

* Retarget the file exclusions from ICU4C 54 to ICU4C 55
 * (improves on-disk footprint on some platforms)

Fixes: nodejs#25855
PR-URL: nodejs#25856
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>

Backport from nodejs/node:
> Originally-Fixes: nodejs/node#2292
> Original-PR-URL: nodejs/node#2293
node was using ICU4C 54 ( released 2014-oct-06 )

* Bump to ICU4C 55 ( released 2015-apr-08)
 * Timezone fixes, translation fixes, bug/performance fixes.
 * Speed improvements in date formatting
 * ICU4C 55 changelog: http://site.icu-project.org/download/55
 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27

* Retarget the file exclusions from ICU4C 54 to ICU4C 55
 * (improves on-disk footprint on some platforms)

Fixes: nodejs#25855

Backport from nodejs/node:
> Originally-Fixes: nodejs/node#2292
> Original-PR-URL: nodejs/node#2293
@srl295
Copy link
Member Author

srl295 commented Aug 13, 2015

@joaocgreis ok… I was going to land it manually, but I don't have to. I removed all but Fixes:. What's next?

@joaocgreis
Copy link
Member

That's it! LGTM. Now just go to https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/ , start a new build with parameters, fill the PR_ID and REVIEWED_BY fields. Note that apply changes is on by default. When it's done, close this with Landed in ####. and the issue with Fixed by ####., with the final commit hash. I can take care of this if you want :)

@srl295
Copy link
Member Author

srl295 commented Aug 13, 2015

@joaocgreis thanks. I requested access, probably better to learn it.

@orangemocha
Copy link
Contributor

@srl295 I had sent you an email with your Jenkins account info a few weeks back. Now I resent it. Let me know if you didn't get it.

@srl295
Copy link
Member Author

srl295 commented Aug 14, 2015

OK, the build is off and running, thanks all.

@joaocgreis
Copy link
Member

@srl295 The SmartOS machines were broken for a few hours, my fault, and the CI job failed, sorry. I started it again, exactly the same parameters: https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/29/

srl295 added a commit that referenced this pull request Aug 14, 2015
node was using ICU4C 54 ( released 2014-oct-06 )

* Bump to ICU4C 55 ( released 2015-apr-08)
 * Timezone fixes, translation fixes, bug/performance fixes.
 * Speed improvements in date formatting
 * ICU4C 55 changelog: http://site.icu-project.org/download/55
 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27

* Retarget the file exclusions from ICU4C 54 to ICU4C 55
 * (improves on-disk footprint on some platforms)

Fixes: #25855

Backport from nodejs/node:
> Originally-Fixes: nodejs/node#2292
> Original-PR-URL: nodejs/node#2293

PR-URL: #25856
Reviewed-By: João Reis <[email protected]>
Reviewed-By: James Snell <[email protected]>
@srl295
Copy link
Member Author

srl295 commented Aug 14, 2015

@joaocgreis +1 - at least I found the right button!

@joaocgreis
Copy link
Member

Landed in 15030f2.

@srl295 All done, thanks!

@joaocgreis joaocgreis closed this Aug 14, 2015
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
node was using ICU4C 54 ( released 2014-oct-06 )

* Bump to ICU4C 55 ( released 2015-apr-08)
 * Timezone fixes, translation fixes, bug/performance fixes.
 * Speed improvements in date formatting
 * ICU4C 55 changelog: http://site.icu-project.org/download/55
 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27

* Retarget the file exclusions from ICU4C 54 to ICU4C 55
 * (improves on-disk footprint on some platforms)

Fixes: nodejs#25855

Backport from nodejs/node:
> Originally-Fixes: nodejs/node#2292
> Original-PR-URL: nodejs/node#2293

PR-URL: nodejs#25856
Reviewed-By: João Reis <[email protected]>
Reviewed-By: James Snell <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants