-
Notifications
You must be signed in to change notification settings - Fork 7.3k
build: Intl: bump ICU4C from 54 to 55 #25856
Conversation
LGTM! |
LGTM, but the PR-URL is corrupted. It can be simply removed, will be added by Jenkins and would get duplicated. |
node was using ICU4C 54 ( released 2014-oct-06 ) * Bump to ICU4C 55 ( released 2015-apr-08) * Timezone fixes, translation fixes, bug/performance fixes. * Speed improvements in date formatting * ICU4C 55 changelog: http://site.icu-project.org/download/55 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27 * Retarget the file exclusions from ICU4C 54 to ICU4C 55 * (improves on-disk footprint on some platforms) Fixes: nodejs#25855 PR-URL: nodejs#25856 Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]> Backport from nodejs/node: > Originally-Fixes: nodejs/node#2292 > Original-PR-URL: nodejs/node#2293
@joaocgreis it's just a placeholder (hash snowman), I didn't have a PR # when it landed. I've fixed this in d9eedaf - sorry for the noise. |
@srl295 Unless you plan to land this manually, only the |
node was using ICU4C 54 ( released 2014-oct-06 ) * Bump to ICU4C 55 ( released 2015-apr-08) * Timezone fixes, translation fixes, bug/performance fixes. * Speed improvements in date formatting * ICU4C 55 changelog: http://site.icu-project.org/download/55 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27 * Retarget the file exclusions from ICU4C 54 to ICU4C 55 * (improves on-disk footprint on some platforms) Fixes: nodejs#25855 PR-URL: nodejs#25856 Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]> Backport from nodejs/node: > Originally-Fixes: nodejs/node#2292 > Original-PR-URL: nodejs/node#2293
node was using ICU4C 54 ( released 2014-oct-06 ) * Bump to ICU4C 55 ( released 2015-apr-08) * Timezone fixes, translation fixes, bug/performance fixes. * Speed improvements in date formatting * ICU4C 55 changelog: http://site.icu-project.org/download/55 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27 * Retarget the file exclusions from ICU4C 54 to ICU4C 55 * (improves on-disk footprint on some platforms) Fixes: nodejs#25855 Backport from nodejs/node: > Originally-Fixes: nodejs/node#2292 > Original-PR-URL: nodejs/node#2293
@joaocgreis ok… I was going to land it manually, but I don't have to. I removed all but |
That's it! LGTM. Now just go to https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/ , start a new build with parameters, fill the PR_ID and REVIEWED_BY fields. Note that apply changes is on by default. When it's done, close this with |
@joaocgreis thanks. I requested access, probably better to learn it. |
@srl295 I had sent you an email with your Jenkins account info a few weeks back. Now I resent it. Let me know if you didn't get it. |
OK, the build is off and running, thanks all. |
@srl295 The SmartOS machines were broken for a few hours, my fault, and the CI job failed, sorry. I started it again, exactly the same parameters: https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/29/ |
node was using ICU4C 54 ( released 2014-oct-06 ) * Bump to ICU4C 55 ( released 2015-apr-08) * Timezone fixes, translation fixes, bug/performance fixes. * Speed improvements in date formatting * ICU4C 55 changelog: http://site.icu-project.org/download/55 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27 * Retarget the file exclusions from ICU4C 54 to ICU4C 55 * (improves on-disk footprint on some platforms) Fixes: #25855 Backport from nodejs/node: > Originally-Fixes: nodejs/node#2292 > Original-PR-URL: nodejs/node#2293 PR-URL: #25856 Reviewed-By: João Reis <[email protected]> Reviewed-By: James Snell <[email protected]>
@joaocgreis +1 - at least I found the right button! |
node was using ICU4C 54 ( released 2014-oct-06 ) * Bump to ICU4C 55 ( released 2015-apr-08) * Timezone fixes, translation fixes, bug/performance fixes. * Speed improvements in date formatting * ICU4C 55 changelog: http://site.icu-project.org/download/55 * CLDR 27 changelog: http://cldr.unicode.org/index/downloads/cldr-27 * Retarget the file exclusions from ICU4C 54 to ICU4C 55 * (improves on-disk footprint on some platforms) Fixes: nodejs#25855 Backport from nodejs/node: > Originally-Fixes: nodejs/node#2292 > Original-PR-URL: nodejs/node#2293 PR-URL: nodejs#25856 Reviewed-By: João Reis <[email protected]> Reviewed-By: James Snell <[email protected]>
Fixes: #25855
node was using ICU4C 54 ( released 2014-oct-06 )
Originally-Fixes: nodejs/node#2292
Original-PR-URL: nodejs/node#2293
@orangemocha @joaocgreis or anyone any comments on the rebase?