This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
child_process.exec doc is inconsistent with actual implementation #9434
Comments
|
@misterdjules I can grab this. |
|
@tyleranton That's great 👍 Please do and submit a PR when you're ready. Also feel free to ping me on #libuv if you need help. Thank you! |
jasnell
pushed a commit
that referenced
this issue
Aug 28, 2015
Changed child_process.exec documentation to reflect that the parameters stdout and stderr are instances of Buffer only if {encoding: null}. Otherwise, they are instances of String with the encoding.
Fixes #9434
removed .DS_Store
PR-URL: #14088
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: piscisaureus - Bert Belder <[email protected]>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this issue
Nov 4, 2016
Changed child_process.exec documentation to reflect that the parameters stdout and stderr are instances of Buffer only if {encoding: null}. Otherwise, they are instances of String with the encoding.
Fixes nodejs#9434
removed .DS_Store
PR-URL: nodejs#14088
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: piscisaureus - Bert Belder <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
child_process.exec' documentation states that the
stdoutandstderrparameters are instances ofBufferby default, but it's actually not the case. They are instances ofBufferonly if{ encoding: null}is passed as options.The documentation of v0.12.x should be fixed to reflect this behavior.
The original intent was that
stdoutandstderrparameters would be instances ofBuffer. If that still holds true, then the change in behavior should be done in master post v0.12.x.Adding to milestone 0.12.2 as it's a quick change.
The text was updated successfully, but these errors were encountered: