Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

No AI_NUMERICSERV on OSX #6

Closed
ujh opened this issue Jun 6, 2009 · 5 comments
Closed

No AI_NUMERICSERV on OSX #6

ujh opened this issue Jun 6, 2009 · 5 comments

Comments

@ujh
Copy link

ujh commented Jun 6, 2009

6e4e228 uses AI_NUMERICSERV which doesn't exist on OSX:

[ 9/17] cxx: src/net.cc -> build/default/src/net_5.o
../src/net.cc:42: error: ‘AI_NUMERICSERV’ was not declared in this scope
../src/net.cc:49: error: ‘AI_NUMERICSERV’ was not declared in this scope
Build failed
-> task failed (err #1):
{task: cxx net.cc -> net_5.o}
make: *** [all] Error 1

@ujh
Copy link
Author

ujh commented Jun 6, 2009

[ 9/17] cxx: src/net.cc -> build/default/src/net_5.o
../src/net.cc:42: error: ‘AI_NUMERICSERV’ was not declared in this scope
../src/net.cc:49: error: ‘AI_NUMERICSERV’ was not declared in this scope
Build failed
 -> task failed (err #1): 
        {task: cxx net.cc -> net_5.o}
make: *** [all] Error 1

@ujh
Copy link
Author

ujh commented Jun 8, 2009

How important is AI_NUMERICSERV anyway? For example this link seems to suggest that you can just define it to 0 if it doesn't exist.

@ujh
Copy link
Author

ujh commented Jun 8, 2009

The naive fix

#ifndef AI_NUMERICSERV
#define AI_NUMERICSERV 0
#endif

Makes the thing compile again and all tests pass, too. BTW. Is it necessary to run

./configure --debug

every time before I run make test?

@ry
Copy link

ry commented Jun 8, 2009

no, you only need to run ./configure --debug once

@ry
Copy link

ry commented Jun 8, 2009

thanks - fixed in 8c146df

HenryRawas pushed a commit to HenryRawas/node that referenced this issue Jun 22, 2011
bnoordhuis added a commit that referenced this issue Apr 10, 2013
Call SetPointerInInternalField(0, NULL) rather than
SetInternalField(0, Undefined()).

Fixes the following spurious NULL pointer dereference in debug builds:

  #0  0x03ad2821 in v8::internal::FixedArrayBase::length ()
  #1  0x03ad1dfc in v8::internal::FixedArray::get ()
  #2  0x03ae05dd in v8::internal::Context::global_object ()
  #3  0x03b6b87d in v8::internal::Context::builtins ()
  #4  0x03ae1871 in v8::internal::Isolate::js_builtins_object ()
  #5  0x03ab4fab in v8::CallV8HeapFunction ()
  #6  0x03ab4d4a in v8::Value::Equals ()
  #7  0x03b4f38b in CheckEqualsHelper ()
  #8  0x03ac0f4b in v8::Object::SetInternalField ()
  #9  0x06a99ddd in node::ObjectWrap::~ObjectWrap ()
  #10 0x06a8b051 in node::Buffer::~Buffer ()
  #11 0x06a8afbb in node::Buffer::~Buffer ()
  #12 0x06a8af5e in node::Buffer::~Buffer ()
  #13 0x06a9e569 in node::ObjectWrap::WeakCallback ()
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants