Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

readline module should not append the 'escape' key to the current line #2876

Closed
joeferner opened this issue Mar 5, 2012 · 4 comments
Closed
Labels

Comments

@joeferner
Copy link

If no modifier keys are pressed and a user presses the 'escape' key a bad character is emitted. The escape key should probably be ignored.

Example: Open a node REPL and hit the escape key.

@bnoordhuis
Copy link
Member

If no modifier keys are pressed and a user presses the 'escape' key a bad character is emitted.

It doesn't for me. With what version of Node and on what operating system are you seeing this behavior?

@joeferner
Copy link
Author

I'm using v0.6.4 on linux. I also had someone try this on a mac. But on the mac it does not show the bad character, it does add the character to the line though. So if you type "1+(escape)1(enter)" the REPL does not think the line is complete and does not execute.

@bnoordhuis
Copy link
Member

Right, I see what you mean and that issue still exists in the current master. Want to try your hand at a patch?

Southern added a commit to Southern/node that referenced this issue Mar 6, 2012
@Southern Southern mentioned this issue Mar 6, 2012
Southern added a commit to Southern/node that referenced this issue Mar 6, 2012
@bnoordhuis
Copy link
Member

Fixed in c84b3c4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants