Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

test: test-crypto-domains should be made non-flaky #25656

Closed
joaocgreis opened this issue Jul 10, 2015 · 2 comments
Closed

test: test-crypto-domains should be made non-flaky #25656

joaocgreis opened this issue Jul 10, 2015 · 2 comments
Assignees
Milestone

Comments

@joaocgreis
Copy link
Member

simple/test-crypto-domains is currently marked as flaky. It should be investigated and made non-flaky.

Quick command for testing:

time (OK=0; NOK=0; for i in `seq 10000`; do ./out/Release/node test/simple/test-crypto-domains.js && OK=$(($OK+1)) || NOK=$(($NOK+1)); echo "$i   OK: $OK   NOT OK: $NOK"; done)

Links:

@joaocgreis joaocgreis added this to the 0.12.8 milestone Jul 10, 2015
@joaocgreis
Copy link
Member Author

I cannot see this test fail on either Linux x64 or Windows 2012r2 x64. It may have been fixed or affect only certain configurations. Last change to the test was made before it was marked flaky.

joaocgreis added a commit that referenced this issue Jul 16, 2015
- `test-crypto-domains` was fixed by
2afa3d8

- All tests under linux appear to be fixed and have not failed recently
on Jenkins

- `test-http-dns-fail` was fixed by the DNS configuration change
mentioned in #8056

Fixes #25656
Fixes #25673

Reviewed-By: Alexis Campailla <[email protected]>
PR-URL: #25676
@joaocgreis
Copy link
Member Author

This test was fixed by 2afa3d8. Although that commit was already made when the test was marked flaky, it was in a different branch.

Unmarked flaky in 78d256e.

jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
- `test-crypto-domains` was fixed by
nodejs/node-v0.x-archive@2afa3d8

- All tests under linux appear to be fixed and have not failed recently
on Jenkins

- `test-http-dns-fail` was fixed by the DNS configuration change
mentioned in nodejs#8056

Fixes nodejs#25656
Fixes nodejs#25673

Reviewed-By: Alexis Campailla <[email protected]>
PR-URL: nodejs#25676
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants