Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Documentation error for TLS.connect() #25271

Closed
iamthechad opened this issue May 8, 2015 · 4 comments
Closed

Documentation error for TLS.connect() #25271

iamthechad opened this issue May 8, 2015 · 4 comments

Comments

@iamthechad
Copy link

While working on code that let to issue #25270, I found that the docs for tls.connect() are incorrect.

It's not specified in the docs, but secureContext can be specified on the options object.
@iamthechad iamthechad mentioned this issue May 8, 2015
Closed
@dnakamura
Copy link

Setting secureContext is not supported, see comments on #25270

@iamthechad
Copy link
Author

Setting secureContext is not supported, but setting ciphers is. The ability to specify ciphers in the options object is also missing from the docs. Can we repurpose this issue to address that, or should I open a new one?

@mhdawson
Copy link
Member

I think its ok to re-purpose this one.

@iamthechad iamthechad mentioned this issue May 14, 2015
Closed
mhdawson pushed a commit that referenced this issue May 21, 2015
@iamthechad @mhdawson
doc: Using ciphers with tls.connect()
a294aee 
Refs #25270,#25271

Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #25325
@iamthechad
Copy link
Author

Fixed via #25325

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamthechad @mhdawson @dnakamura