Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
build: ./configure pass positional args to gyp
Browse files Browse the repository at this point in the history
use `--` to specify the arguments you want to pass directly to gyp.

for example: `./configure -- --no-parallel -Dsome_define=foo`

fixes #6370
  • Loading branch information
tjfontaine committed Dec 7, 2013
1 parent 5cfee92 commit b5e1619
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -695,13 +695,17 @@ config = '\n'.join(map('='.join, config.iteritems())) + '\n'
write('config.mk',
'# Do not edit. Generated by the configure script.\n' + config)

gyp_args = [sys.executable, 'tools/gyp_node.py']

if options.use_ninja:
gyp_args = ['-f', 'ninja-' + flavor]
gyp_args += ['-f', 'ninja-' + flavor]
elif options.use_xcode:
gyp_args = ['-f', 'xcode']
gyp_args += ['-f', 'xcode']
elif flavor == 'win':
gyp_args = ['-f', 'msvs', '-G', 'msvs_version=auto']
gyp_args += ['-f', 'msvs', '-G', 'msvs_version=auto']
else:
gyp_args = ['-f', 'make-' + flavor]
gyp_args += ['-f', 'make-' + flavor]

gyp_args += args

subprocess.call([sys.executable, 'tools/gyp_node.py'] + gyp_args)
subprocess.call(gyp_args)

0 comments on commit b5e1619

Please sign in to comment.