Apply gyp patch that adds support for setting the compiler dialect on OS X #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of some feedback on this? It's fairly important for users of modern C++. Thanks for your time. |
|
👍 - I will also need c++11 support soon. |
TooTallNate
added a commit
that referenced
this pull request
Jun 17, 2013
Apply gyp patch that adds support for setting the compiler dialect on OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code uses some c++0x features - with the version of gyp you were using previously it was not possible to override the dialect for the compiler (using CLANG_CXX_LANGUAGE_STANDARD in the xcode_settings section) - applying this upstream patch to gyp fixes that.