Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common.gypi #110

Closed
indutny opened this issue Jul 27, 2012 · 2 comments
Closed

common.gypi #110

indutny opened this issue Jul 27, 2012 · 2 comments

Comments

@indutny
Copy link
Member

indutny commented Jul 27, 2012

Would it be hard to support common.gypi file (as we do it in node.js now?)
@TooTallNate
Copy link
Contributor

The same common.gypi file that node builds with is used when building addons with node-gyp.

Are you needing to create another .gypi file that is used throughout your module and its dependencies? It would be easy to add support for. It could either:

  • Autodetect a common.gypi or config.gypi file, since those seem to be the conventional names.
  • Accept a node-gyp configure --include=common.gypi flag that you could use to add gypi files.

Thoughts? I'm leaning towards the auto detection.

@TooTallNate
Copy link
Contributor

Auto-detection implemented in 2e5e6a6.

@alexandrubau alexandrubau mentioned this issue Feb 25, 2018
Closed
targos pushed a commit to targos/node-gyp that referenced this issue Aug 22, 2021
@github-actions
chore: release 0.9.1 (nodejs#110)
dc08c15 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TooTallNate @indutny