Skip to content

Commit

Permalink
feat: prohibit compiling with ClangCL on Windows (#3098)
Browse files Browse the repository at this point in the history
Disables trying to compile with ClangCL on Windows. Was required to enable native tests in the Node.js CI for the ClangCL produced binaries.

Refs: nodejs/node#55784
  • Loading branch information
StefanStojanovic authored Nov 29, 2024
1 parent e6f4ede commit 88260bf
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/create-config-gypi.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ async function getCurrentConfigGypi ({ gyp, nodeDir, vsInfo, python }) {
}
}
variables.msbuild_path = vsInfo.msBuild
if (config.variables.clang === 1) {
config.variables.clang = 0
}
}

// loop through the rest of the opts and add the unknown ones as variables.
Expand Down

0 comments on commit 88260bf

Please sign in to comment.