Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pr_checker): do not count non-approving reviews #680

Merged
merged 1 commit into from
Mar 18, 2023
Merged

fix(pr_checker): do not count non-approving reviews #680

merged 1 commit into from
Mar 18, 2023

Commits on Mar 8, 2023

  1. fix(pr_checker): do not count non-approving reviews 

    Before this commit, any review after the last commit would
disable the warning and let the CQ land the PR. This commit makes sure
that only approving reviews from collaborators are taken into account to
decide if a PR is ready to land.
    @aduh95
    aduh95 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7506bbe View commit details
    Browse the repository at this point in the history