[Converge] path: refactor for performance and consistency

[jasnell]

See: nodejs/node-v0.x-archive@c66f8c2
@misterdjules @woollybogger

Original commit message:

Improve performance by:
+ Not leaking the `arguments` object!
+ Getting the last character of a string by index, instead of
  with `.substr()` or `.slice()`

Improve code consistency by:
+ Using `[]` instead of `.charAt()` where possible
+ Using a function declaration instead of a var declaration
+ Using `.slice()` with clearer arguments
+ Checking if `dir` is truthy in `win32.format`
  (added tests for this)

Improve both by:
+ Making the reusable `trimArray()` function
+ Standardizing getting certain path statistics with
  the new `win32StatPath()` function

[Fishrock123]

Maybe port to io.js, conflict isn't large.

[nwoltman]

So should this commit be added to the io.js repo and not this new repo?

[Fishrock123]

@woollybogger again, probably. If you'd be willing to do it, that would be great! :)

[jasnell]

Eventually all of the io.js commits will make their way here anyway. So it
generally doesn't matter, especially for something like this.
On May 22, 2015 3:53 PM, "Jeremiah Senkpiel" [email protected]
wrote:

@woollybogger https://github.com/woollybogger again, probably. If you'd
be willing to do it, that would be great! :)

—
Reply to this email directly or view it on GitHub
nodejs/node#35 (comment).

[Fishrock123]

While true, some of this is just good maintenance for the io.js line.

[jasnell]

👍
On May 22, 2015 4:02 PM, "Jeremiah Senkpiel" [email protected]
wrote:

While true, some of this is just good maintenance for the io.js line.

—
Reply to this email directly or view it on GitHub
nodejs/node#35 (comment).

[jasnell]

Closing this in favor of nodejs/node#1778

[Fishrock123]

Landed in io.js: nodejs/node#1778 (comment)