Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

fix build break from JsCopyString #349

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

kunalspathak
Copy link
Member

Updated the parameters passed to JsCopyString.
Refs #348

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

chakrashim

@kunalspathak
Copy link
Member Author

@MSLaguana
Copy link
Contributor

LGTM, hopefully nothing unexpected happens in the CI

@kunalspathak
Copy link
Member Author

Seeing ARM failures in CI. Will investigate.

@kunalspathak
Copy link
Member Author

Looks like CI ARM machine is in bad state. I don't see nightly build for ARM as well at https://nodejs.org/download/chakracore-nightly/v9.0.0-nightly201707261ab71b9a03/

@kunalspathak
Copy link
Member Author

@joaocgreis

@kfarnung
Copy link
Contributor

It looks like the issue was introduced in nodejs/node@ed21cb1 and should affect all builds where INTL is disabled.

@kunalspathak
Copy link
Member Author

Looks like nodejs/node#13644 this broke the ARM builds because for node-chakracore we disable Intl building. @MSLaguana is trying to see if upstream node build fails with --without-intl flag and if yes, we need PR upstream to fix the issue. For now, i will ignore the arm failure.

@kunalspathak kunalspathak merged commit 37d92c9 into nodejs:master Jul 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants