This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
n-api: enable napi_wrap() to work with any object #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Change to inserting an external object into the wrapper object's prototype chain, instead of injecting an alternate `this` object in the constructor callback adapter. The latter approach didn't work in certain scenarios because the JSRT runtime still returned the original `this` object. And with this change, the setting and checking of the extension flag, which distinguished wrapper objects from external objects, can be removed. I was never happy with that abuse of the extension flag even when I coded it. Also removing the CallbackInfo.returnValue field which is not used anymore (since we switched to direct return values).
|
Pushed a commit to address feedback at nodejs/node#13250 (comment), so the Node-ChakraCore implementation stays in sync with Node-V8, and passes the additional test cases I added there. |
kfarnung
reviewed
Jun 2, 2017
src/node_api_jsrt.cc
Outdated
| bool hasExternalData = false; | ||
| do { | ||
| CHECK_JSRT(JsGetPrototype(wrapper, &wrapper)); | ||
| if (wrapper == nullptr) { |
|
CI: https://ci.nodejs.org/job/chakracore-test/84/ |
|
Looks like the CI failures were all related to processes launched by skipped tests not getting cleaned up. You should be good to go. |
jasongin
added a commit
that referenced
this pull request
Jun 2, 2017
Change to inserting an external object into the wrapper object's prototype chain, instead of injecting an alternate `this` object in the constructor callback adapter. The latter approach didn't work in certain scenarios because the JSRT runtime still returned the original `this` object. And with this change, the setting and checking of the extension flag, which distinguished wrapper objects from external objects, can be removed. Also removing the CallbackInfo.returnValue field which is not used anymore (since we switched to direct return values). PR-URL: #269 Reviewed-By: Taylor Woll <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
|
Landed as 9cc4824 |
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jun 5, 2017
Change to inserting an external object into the wrapper object's prototype chain, instead of injecting an alternate `this` object in the constructor callback adapter. The latter approach didn't work in certain scenarios because the JSRT runtime still returned the original `this` object. And with this change, the setting and checking of the extension flag, which distinguished wrapper objects from external objects, can be removed. Also removing the CallbackInfo.returnValue field which is not used anymore (since we switched to direct return values). PR-URL: nodejs#269 Reviewed-By: Taylor Woll <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jun 5, 2017
Change to inserting an external object into the wrapper object's prototype chain, instead of injecting an alternate `this` object in the constructor callback adapter. The latter approach didn't work in certain scenarios because the JSRT runtime still returned the original `this` object. And with this change, the setting and checking of the extension flag, which distinguished wrapper objects from external objects, can be removed. Also removing the CallbackInfo.returnValue field which is not used anymore (since we switched to direct return values). PR-URL: nodejs#269 Reviewed-By: Taylor Woll <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to inserting an external object into the wrapper object's prototype chain, instead of injecting an alternate
thisobject in the constructor callback adapter. The latter approach didn't work in certain scenarios because the JSRT runtime still returned the originalthisobject.And with this change, the setting and checking of the extension flag, which distinguished wrapper objects from external objects, can be removed. I was never happy with that abuse of the extension flag even when I coded it.
Also removing the CallbackInfo.returnValue field which is not used anymore (since we switched to direct return values).
See also my PR at nodejs/node#13250, which gives further details and includes a new test case that validates this change. While it's not included in this PR, I have manually run that test to validate this change.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api