support bigint64/biguint64 in TypedArray::ElementSize() #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
approved these changes
Apr 20, 2020
napi-inl.h
Outdated
| @@ -1628,6 +1628,10 @@ inline uint8_t TypedArray::ElementSize() const { | |||
| case napi_float32_array: | |||
| return 4; | |||
| case napi_float64_array: | |||
| #ifdef NAPI_EXPERIMENTAL | |||
There was a problem hiding this comment.
N-API BigInt support has been out of experimental and can be guarded with
#if (NAPI_VERSION >= 6)
Check out #697 for more contexts.
8 tasks
mhdawson
reviewed
Apr 20, 2020
napi-inl.h
Outdated
| @@ -1628,6 +1628,10 @@ inline uint8_t TypedArray::ElementSize() const { | |||
| case napi_float32_array: | |||
| return 4; | |||
| case napi_float64_array: | |||
| #ifdef NAPI_EXPERIMENTAL | |||
There was a problem hiding this comment.
Suggested change
| #ifdef NAPI_EXPERIMENTAL | |
| #if (NAPI_VERSION > 5) |
mhdawson
reviewed
Apr 20, 2020
napi-inl.h
Outdated
| #ifdef NAPI_EXPERIMENTAL | ||
| case napi_bigint64_array: | ||
| case napi_biguint64_array: | ||
| #endif // NAPI_EXPERIMENTAL |
There was a problem hiding this comment.
Suggested change
| #endif // NAPI_EXPERIMENTAL | |
| #endif // NAPI_VERSION > 5 |
NickNaso
approved these changes
Apr 20, 2020
Co-Authored-By: Gabriel Schulhof <[email protected]>
mhdawson
pushed a commit
that referenced
this pull request
Apr 24, 2020
PR-URL: #705 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
|
Landed as 4de23c9 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#705 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#705 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#705 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#705 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.