Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add Napi::BigInt::New() overload for uint64_t #672

Merged
merged 1 commit into from
Feb 17, 2020
Merged

doc: Add Napi::BigInt::New() overload for uint64_t #672

merged 1 commit into from
Feb 17, 2020

Conversation

ikokostya
Copy link
Contributor

Link to the source code:

node-addon-api/napi.h

Lines 349 to 352 in 7f56a78

static BigInt New(
napi_env env, ///< N-API environment
uint64_t value ///< Number value
);

NickNaso
NickNaso approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit cb498bb into nodejs:master Feb 17, 2020
@ikokostya ikokostya deleted the bigint-doc-uint64 branch February 18, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikokostya @NickNaso @gabrielschulhof @legendecas @mhdawson