Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document adding -fvisibility=hidden flag for macOS users #460

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Document adding -fvisibility=hidden flag for macOS users #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b527ed4
-fvisibility=hidden flag for macOS user
NickNaso Mar 20, 2019
7340204
Fixed as requested in review
NickNaso Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions doc/setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,19 @@ To use **N-API** in a native module:
```gyp
'defines': [ 'NAPI_DISABLE_CPP_EXCEPTIONS' ],
```

4. Include `napi.h` in the native module code.
4. If you would like your native addon to support OSX, please also add the
following settings in the `binding.gyp` file:

```gyp
['OS=="mac"', {
'cflags+': ['-fvisibility=hidden'],
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
}
}]
```

5. Include `napi.h` in the native module code.
To ensure only ABI-stable APIs are used, DO NOT include
`node.h`, `nan.h`, or `v8.h`.

Expand Down