Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added references to changelog maker tool and other minor fixes #394

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Added references to changelog maker tool and other minor fixes #394

merged 2 commits into from
Jan 8, 2019

Conversation

NickNaso
Copy link
Member

I added some reference about which tool use to generate the changelog and other minor fixes.

doc/creating_a_release.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso
Copy link
Member Author

NickNaso commented Jan 2, 2019

What do I need to change here? Someone could review?

@mhdawson
Copy link
Member

mhdawson commented Jan 3, 2019

I think it just needs to be landed. You should have write access and be able to land it.

@NickNaso NickNaso merged commit 44f0695 into nodejs:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants