Set up unit tests #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set up a pattern for organizing a .cc and .js test files roughly corresponding to each class to be tested - Add unit tests for the Function and Error classes - Update test binding.gyp file to build on Windows (fix quotes) - Update test binding.gyp and README to enable exceptions with MSVC - Fix type of CallbackInfo::This
addaleax
approved these changes
Apr 18, 2017
test/error.js
Outdated
| let err = binding.error.catchError( | ||
| () => { throw new TypeError('test'); }); | ||
| assert(err instanceof TypeError); | ||
| assert.equal(err.message, 'test'); |
There was a problem hiding this comment.
Just fyi, this is how we’d write this in Node core right now:
{
const err = binding.error.catchError(
() => { throw new TypeError('test'); });
assert(err instanceof TypeError);
assert.strictEqual(err.message, 'test');
}(const wherever possible, block scope + always using strict equality asserts)
test/index.js
Outdated
| const assert = require('assert'); | ||
| global.buildType = process.config.target_defaults.default_configuration; | ||
| global.binding = require(`./build/${buildType}/binding.node`); | ||
| global.assert = require('assert'); |
There was a problem hiding this comment.
This means that somebody looking at the test files themselves might need to look up where those “magic” globals come from … I’d be very okay with just copying these lines into the test files themselves :)
That would also have the advantage that they are are runnable as standalone node scripts, which might be nice when the test suite is bigger and takes longer to run.
There was a problem hiding this comment.
Yes, I didn't really like this use of global either. Ability to run the test files individually is a good point.
mhdawson
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roughly corresponding to each class to be tested