-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the object test into smaller tests (get/set/delete/hasOwnProperty) #183
Conversation
@mhdawson PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I'm on vacation for the next week so I'll look at landing when I get back or if another reviewer takes a look between now and then they can go head earlier.
@mhdawson Thank you for review and I'll request another reviewer. Have a good vacation :) |
@addaleax Could you please review this patch if you have a minute? |
Ran the tests locally on linux and I got this failure:
With this PR backed out the tests ran ok. @romandev can you take a look. You can run the tests with npm-test |
This change breaks the object test into smaller tests for the following reasons: - Smaller tests are better than very large one. (e.g. readability) - Before this patch, we have missed some test cases. For example, there are four overloading versions of the deleteProperty() method, but we haven't tested them all until now.
@mhdawson Done. I've just fixed the error. Thank you! |
Split the object test into smaller tests (get/set/delete/hasOwnProperty) This change breaks the object test into smaller tests for the following reasons: - Smaller tests are better than very large one. (e.g. readability) - Before this patch, we have missed some test cases. For example, there are four overloading versions of the deleteProperty() method, but we haven't tested them all until now. PR-URL: #183 Reviewed-By: Michael Dawson <[email protected]>
Split the object test into smaller tests (get/set/delete/hasOwnProperty) This change breaks the object test into smaller tests for the following reasons: - Smaller tests are better than very large one. (e.g. readability) - Before this patch, we have missed some test cases. For example, there are four overloading versions of the deleteProperty() method, but we haven't tested them all until now. PR-URL: nodejs/node-addon-api#183 Reviewed-By: Michael Dawson <[email protected]>
Split the object test into smaller tests (get/set/delete/hasOwnProperty) This change breaks the object test into smaller tests for the following reasons: - Smaller tests are better than very large one. (e.g. readability) - Before this patch, we have missed some test cases. For example, there are four overloading versions of the deleteProperty() method, but we haven't tested them all until now. PR-URL: nodejs/node-addon-api#183 Reviewed-By: Michael Dawson <[email protected]>
Split the object test into smaller tests (get/set/delete/hasOwnProperty) This change breaks the object test into smaller tests for the following reasons: - Smaller tests are better than very large one. (e.g. readability) - Before this patch, we have missed some test cases. For example, there are four overloading versions of the deleteProperty() method, but we haven't tested them all until now. PR-URL: nodejs/node-addon-api#183 Reviewed-By: Michael Dawson <[email protected]>
Split the object test into smaller tests (get/set/delete/hasOwnProperty) This change breaks the object test into smaller tests for the following reasons: - Smaller tests are better than very large one. (e.g. readability) - Before this patch, we have missed some test cases. For example, there are four overloading versions of the deleteProperty() method, but we haven't tested them all until now. PR-URL: nodejs/node-addon-api#183 Reviewed-By: Michael Dawson <[email protected]>
This change breaks the object test into smaller tests for the following
reasons:
there are four overloading versions of the deleteProperty() method,
but we haven't tested them all until now.