Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Napi::details::AttachData via napi_add_finalizer #557

Closed
gabrielschulhof opened this issue Oct 6, 2019 · 0 comments
Closed

Implement Napi::details::AttachData via napi_add_finalizer #557

gabrielschulhof opened this issue Oct 6, 2019 · 0 comments

Comments

@gabrielschulhof
Copy link
Contributor

Let's do this when napi_add_finalizer is no longer experimental.

Re: #551 (comment)
gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Oct 28, 2019
src: attach data with napi_add_finalizer
d484d03 
Use `napi_add_finalizer()` to attach data when building against N-API 5
instead of the symbol + external approach that leaves a trace on the
target object.

Fixes: nodejs#557
@gabrielschulhof gabrielschulhof mentioned this issue Oct 28, 2019
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Oct 29, 2019
src: attach data with napi_add_finalizer
301c5bf 
Use `napi_add_finalizer()` to attach data when building against N-API 5
instead of the symbol + external approach that leaves a trace on the
target object.

Fixes: nodejs#557
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: attach data with napi_add_finalizer
a9dc1be 
Use `napi_add_finalizer()` to attach data when building against N-API 5
instead of the symbol + external approach that leaves a trace on the
target object.

Fixes: nodejs/node-addon-api#557
PR-URL: nodejs/node-addon-api#577
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: attach data with napi_add_finalizer
fbff84f 
Use `napi_add_finalizer()` to attach data when building against N-API 5
instead of the symbol + external approach that leaves a trace on the
target object.

Fixes: nodejs/node-addon-api#557
PR-URL: nodejs/node-addon-api#577
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: attach data with napi_add_finalizer
f5c0ea6 
Use `napi_add_finalizer()` to attach data when building against N-API 5
instead of the symbol + external approach that leaves a trace on the
target object.

Fixes: nodejs/node-addon-api#557
PR-URL: nodejs/node-addon-api#577
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: attach data with napi_add_finalizer
c5a920e 
Use `napi_add_finalizer()` to attach data when building against N-API 5
instead of the symbol + external approach that leaves a trace on the
target object.

Fixes: nodejs/node-addon-api#557
PR-URL: nodejs/node-addon-api#577
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: attach data with napi_add_finalizer gabrielschulhof/node-addon-api
1 participant
@gabrielschulhof