Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-addon-api test failures on linuxOne and AIX #230

Closed
mhdawson opened this issue Mar 5, 2018 · 1 comment
Closed

node-addon-api test failures on linuxOne and AIX #230

mhdawson opened this issue Mar 5, 2018 · 1 comment

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 5, 2018

After I landed this on Friday 9c4d321. There have been failures in the nightly runs across platforms.

I'm seeing faliures on AIX and linuxOne. Likely and issue with endianess as they are both big endian.

https://ci.nodejs.org/job/node-test-node-addon-api/MACHINE=rhel72-s390x/207/console

> [email protected] test /data/iojs/build/workspace/node-test-node-addon-api/MACHINE/rhel72-s390x/node-addon-api
> node test

Starting test suite

Running test 'arraybuffer'
Running test 'asyncworker'
Running test 'basic_types/number'
Running test 'basic_types/value'
Running test 'buffer'
Running test 'dataview/dataview'
Running test 'dataview/dataview_read_write'
assert.js:74
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: 4.170874845499384e-8 strictEqual 10.199999809265137
    at testReadData (/data/iojs/build/workspace/node-test-node-addon-api/MACHINE/rhel72-s390x/node-addon-api/test/dataview/dataview_read_write.js:35:12)
    at test (/data/iojs/build/workspace/node-test-node-addon-api/MACHINE/rhel72-s390x/node-addon-api/test/dataview/dataview_read_write.js:60:3)
    at Object.<anonymous> (/data/iojs/build/workspace/node-test-node-addon-api/MACHINE/rhel72-s390x/node-addon-api/test/dataview/dataview_read_write.js:6:1)
    at Module._compile (module.js:666:30)
    at Object.Module._extensions..js (module.js:677:10)

@jBarz, @romandev can you take a look.
@romandev
Copy link
Contributor

romandev commented Mar 5, 2018

I'll investigate this issue.

romandev added a commit to romandev/node-addon-api that referenced this issue Mar 5, 2018
@romandev
Fix test failures on linuxOne and AIX
ecb684e 
Currently, the test only considers little endian. So, this patch adds
a endian check function(IsLittleEndian()) and then use it instead of
hardcoded value.

This fixes nodejs#230 issue.
@romandev romandev mentioned this issue Mar 5, 2018
Closed
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
Fix test failures on linuxOne and AIX
a09de4c 
Currently, the test only considers little endian. So, this patch adds
a endian check function(IsLittleEndian()) and then use it instead of
hardcoded value.

Fixes: nodejs/node-addon-api#230
PR-URL: nodejs/node-addon-api#232
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
Fix test failures on linuxOne and AIX
3c9e134 
Currently, the test only considers little endian. So, this patch adds
a endian check function(IsLittleEndian()) and then use it instead of
hardcoded value.

Fixes: nodejs/node-addon-api#230
PR-URL: nodejs/node-addon-api#232
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
Fix test failures on linuxOne and AIX
a15b708 
Currently, the test only considers little endian. So, this patch adds
a endian check function(IsLittleEndian()) and then use it instead of
hardcoded value.

Fixes: nodejs/node-addon-api#230
PR-URL: nodejs/node-addon-api#232
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
Fix test failures on linuxOne and AIX
7c2c6cd 
Currently, the test only considers little endian. So, this patch adds
a endian check function(IsLittleEndian()) and then use it instead of
hardcoded value.

Fixes: nodejs/node-addon-api#230
PR-URL: nodejs/node-addon-api#232
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test failures on linuxOne and AIX romandev/node-addon-api
2 participants
@romandev @mhdawson