Add ObjectWrap<T> subclass in instance data

nodejs · Feb 3, 2020 · 433a1a1 · 433a1a1
1 parent 89aa6b6
commit 433a1a1
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 7 deletions.
diff --git a/test/addon_data.cc b/test/addon_data.cc
@@ -4,8 +4,36 @@
 
 class Addon {
  public:
-  Addon() {}
+  class VerboseIndicator : public Napi::ObjectWrap<VerboseIndicator> {
+   public:
+    VerboseIndicator(const Napi::CallbackInfo& info):
+        Napi::ObjectWrap<VerboseIndicator>(info) {
+      info.This().As<Napi::Object>()["verbose"] =
+          Napi::Boolean::New(info.Env(),
+                             info.Env().GetInstanceData<Addon>()->verbose);
+    }
+
+    Napi::Value Getter(const Napi::CallbackInfo& info) {
+      return Napi::Boolean::New(info.Env(),
+                                info.Env().GetInstanceData<Addon>()->verbose);
+    }
+
+    void Setter(const Napi::CallbackInfo& info, const Napi::Value& val) {
+      info.Env().GetInstanceData<Addon>()->verbose = val.As<Napi::Boolean>();
+    }
+
+    static Napi::FunctionReference Init(Napi::Env env) {
+      return Napi::Persistent(DefineClass(env, "VerboseIndicator", {
+        InstanceAccessor<
+                         &VerboseIndicator::Getter,
+                         &VerboseIndicator::Setter>("verbose")
+      }));
+    }
+  };
+
+  Addon(Napi::Env env): VerboseIndicator(VerboseIndicator::Init(env)) {}
   bool verbose = false;
+  Napi::FunctionReference VerboseIndicator;
   ~Addon() {
     if (verbose) {
       fprintf(stderr, "addon_data: Addon::~Addon\n");
@@ -14,16 +42,15 @@ class Addon {
 };
 
 static Napi::Value Getter(const Napi::CallbackInfo& info) {
-  return Napi::Boolean::New(info.Env(),
-                            info.Env().GetInstanceData<Addon>()->verbose);
+  return info.Env().GetInstanceData<Addon>()->VerboseIndicator.New({});
 }
 
 static void Setter(const Napi::CallbackInfo& info) {
   info.Env().GetInstanceData<Addon>()->verbose = info[0].As<Napi::Boolean>();
 }
 
 Napi::Object InitAddonData(Napi::Env env) {
-  env.SetInstanceData(new Addon());
+  env.SetInstanceData(new Addon(env));
   Napi::Object result = Napi::Object::New(env);
 
   result.DefineProperties({

diff --git a/test/addon_data.js b/test/addon_data.js
@@ -12,11 +12,11 @@ function test(bindingName) {
   const binding = require(bindingName);
 
   // Make sure it is possible to get/set instance data.
-  assert.strictEqual(binding.addon_data.verbose, false);
+  assert.strictEqual(binding.addon_data.verbose.verbose, false);
   binding.addon_data.verbose = true;
-  assert.strictEqual(binding.addon_data.verbose, true);
+  assert.strictEqual(binding.addon_data.verbose.verbose, true);
   binding.addon_data.verbose = false;
-  assert.strictEqual(binding.addon_data.verbose, false);
+  assert.strictEqual(binding.addon_data.verbose.verbose, false);
 
   // Make sure the instance data finalizer is called at process exit.
   const child = spawn(process.execPath, [