Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary local variable declaration #870

Merged
merged 1 commit into from
Oct 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions nan.h
Original file line number Diff line number Diff line change
Expand Up @@ -2141,10 +2141,7 @@ class AsyncProgressWorkerBase : public AsyncBareProgressWorker<T> {
private:
void SendProgress_(const T *data, size_t count) {
T *new_data = new T[count];
{
T *it = new_data;
std::copy(data, data + count, it);
}
std::copy(data, data + count, new_data);

uv_mutex_lock(&this->async_lock);
T *old_data = asyncdata_;
Expand Down Expand Up @@ -2263,10 +2260,7 @@ class AsyncProgressQueueWorker : public AsyncBareProgressQueueWorker<T> {
private:
void SendProgress_(const T *data, size_t count) {
T *new_data = new T[count];
{
T *it = new_data;
std::copy(data, data + count, it);
}
std::copy(data, data + count, new_data);

uv_mutex_lock(&async_lock);
asyncdata_.push(std::pair<T*, size_t>(new_data, count));
Expand Down