Add NAN_MODULE_WORKER_ENABLED macro as a replacement for NAN_MODULE that supports multiple workers #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat supports multiple workers Uses the named symbol node_register_module_v## variant of registration that works on node 10.5 with --experimental-workers. May need updating in the future if node requires native modules to explicitly opt in to multiple isolate support.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…ck so that it's consistently declared
|
Thank you. |
yuche
added a commit
to yuche/node-xxhash
that referenced
this pull request
Aug 5, 2020
yuche
added a commit
to yuche/node-xxhash
that referenced
this pull request
Aug 5, 2020
bongnv
pushed a commit
to bongnv/superstring
that referenced
this pull request
Nov 10, 2022
All native modules used Electron be context-ware before when upgrading to Electron 14. [ref](electron/electron#18397). `superstring` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware. Please check electron/electron#18397 and nodejs/nan#792 for more detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the named symbol
node_register_module_v##variant of registration that works to support loading in multiple workers on node 10.5 with--experimental-workers.This may need updating in the future if/when node requires native modules to explicitly opt in to multiple isolate support.