Readded missing String constructors. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 let's get a patch release out for 1.5 soon, preferably with #239 too I think |
|
LGTM. |
kkoopa
added a commit
that referenced
this pull request
Jan 17, 2015
Readded missing String constructors.
kkoopa
referenced
this pull request
in mscdex/mmmagic
Jan 17, 2015
Until nan supports v8's static empty string value, we will have to use an explicit empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Stringconstructors that were inadvertently omitted in theNanNewrewrite.Fixes #227.
R=@agnat