Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: support node.js >= 8 #82

Merged
merged 2 commits into from
May 2, 2017
Merged

src,test: support node.js >= 8 #82

merged 2 commits into from
May 2, 2017

Conversation

bnoordhuis
Copy link
Member

This depends on changes that haven't been upstreamed yet. Diff for the eager:

diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py
index 8857134..8f8d8a1 100644
--- a/deps/v8/tools/gen-postmortem-metadata.py
+++ b/deps/v8/tools/gen-postmortem-metadata.py
@@ -99,6 +99,22 @@ consts_misc = [
         'value': 'kAccessor' },
     { 'name': 'prop_kind_mask',
         'value': 'PropertyDetails::KindField::kMask' },
+    { 'name': 'prop_location_Descriptor',
+        'value': 'kDescriptor' },
+    { 'name': 'prop_location_Field',
+        'value': 'kField' },
+    { 'name': 'prop_location_mask',
+        'value': 'PropertyDetails::LocationField::kMask' },
+    { 'name': 'prop_location_shift',
+        'value': 'PropertyDetails::LocationField::kShift' },
+    { 'name': 'prop_attributes_NONE', 'value': 'NONE' },
+    { 'name': 'prop_attributes_READ_ONLY', 'value': 'READ_ONLY' },
+    { 'name': 'prop_attributes_DONT_ENUM', 'value': 'DONT_ENUM' },
+    { 'name': 'prop_attributes_DONT_DELETE', 'value': 'DONT_DELETE' },
+    { 'name': 'prop_attributes_mask',
+        'value': 'PropertyDetails::AttributesField::kMask' },
+    { 'name': 'prop_attributes_shift',
+        'value': 'PropertyDetails::AttributesField::kShift' },
     { 'name': 'prop_index_mask',
         'value': 'PropertyDetails::FieldIndexField::kMask' },
     { 'name': 'prop_index_shift',

Verified locally to work with node.js v4, v6, v7 and v8.0.0-pre and is clang-format clean.

hhellyer

This comment was marked as off-topic.

@hhellyer
Copy link
Contributor

I'm going to have a proper look at this, I need to update my Node built tree and put your gen-postmortem-metadata.py patch in first though. (Didn't want you to think this is being ignored!)

@hhellyer
Copy link
Contributor

Ok, doing the updates took less time than expected. :-)
LGTM with the updated gen-postmortem-metadata.py in the build.

@indutny - Should we merge this or wait until Node 8 releases?

@bnoordhuis
Copy link
Member Author

Dropped the single-character variable names. The V8 patch landed in node.js master, see nodejs/node#12722. Barring objections, I'll merge this tomorrow.

PR-URL: #82
Reviewed-By: Howard Hellyer <[email protected]>
Teach the object property decoder to recognize the layout of objects
in newer versions of V8.

Fixes: #81
PR-URL: #82
Refs: https://codereview.chromium.org/2842843004/
Refs: nodejs/node#12722
Reviewed-By: Howard Hellyer <[email protected]>
@bnoordhuis bnoordhuis merged commit b73e042 into nodejs:master May 2, 2017
@bnoordhuis bnoordhuis deleted the n8 branch May 2, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants