-
Notifications
You must be signed in to change notification settings - Fork 129
Adds i18n footer links (for all known active languages) #258
Adds i18n footer links (for all known active languages) #258
Conversation
Can the i18n teams please check the following:
@iojs/iojs-bg I used Wikipedia's list of language names as inspiration. |
Any plans on adding something for missing languages with a capture page to see the interest in the language? |
Italian it's OK |
@AdriVanHoudt good timing! I just semi-addressed this in an update to the PR description. Short term answer: no Long term answer: yes Currently we have 99% coverage of articles, so this is a non-issue. Soon, we'll be adding new pages and it will be very important to fall back to English but consider cases like:
For now we're not doing any sort of magical language detection. Nobody will be redirected/forced to use a language they didn't plan to see :) |
ko looks okey. |
@snostorm I like the fallback + native language notification. This is just something for us (@iojs/iojs-nl) because we feel that dutch speaking people in general do all dev in english so translating only seems needed if there is really demand for it. |
Russian / Русский LGTM |
@marocchino noted. I'll take any incoming small responses like this and bundle them in to a patch before merging. |
FR L10n for latest i18n-refactoring template JSON
Oh, Thank you. :3 |
Spanish its OK. Regarding to translate the Language I think so but I'll ask around :) on iojs-es and come back here ;) |
Note to translators who might PR/post translations here, there's also a new string "contribute-message" which was requested in #225 Lets you localize the following however you like (a joke, url to your local group, both projects, etc.) |
Right, I'll take care of that as well @snostorm |
When #256 is merged you can add a link to the Norwegian translation as |
German is ok. |
id looks okay. |
Turkish is ok. |
👍 Portuguese |
👍 Greek |
Finnish 👍 |
Japanese 👍 |
Myabe 正體中文 for tw will be better On 2015年3月4日週三 12:12 Haoliang Gao [email protected] wrote:
|
@snostorm I just ran both |
+1 |
"current_v8": "4.1.0.21" | ||
"current_v8": "4.1.0.21", | ||
"languages": [ | ||
{"code": "cn", "name": "中文", "name-en": "Chinese"}, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
regarding "current_version": "1.4.3" and "current_v8": "4.1.0.21", |
I would like my peers at @iojs/iojs-pt to review/approve this Pull Request
5f29f68
to
a585848
Compare
FYI I'll probably merge this soon. I think I factored in everyone's comments although there was a lot of inline brainstorming / discussion around If there are any additional tweaks feel free to fix with additional PRs to the master branch once this lands. @parroit, take a look at line 3 of https://raw.githubusercontent.com/iojs/website/template-build-refactor_i18n-footer/content/en/es6.md (or almost any other Under the |
[pt_PT] Update template.json
Adds i18n footer links (for all known active languages)
Something seems off on line 90 of gulp/tasks/templates.js.
It's a backtick instead of a quote. Gives me an Unexpected Token ILLEGAL while trying to locally develop. |
@diagramatics this will only run against |
@snostorm Ah, thanks. I just updated node to the new version because of another error. I'll rollback that commit on my PR. |
@snostorm Are you aware that on translated pages, the FAQ link still leads to the English version? <a href="/faq.html">Συχνές ερωτήσεις</a> |
Oh, ok. 👍 |
Since many localizations are following this thread I'll direct you to #276 which contains the ongoing build process work which was a followup to some of the effort which was started here. At this point we're looking for feedback / suggestions on the patterns used in the sample home.html within that pull request. Some files (like the homepage) would move to sharing a single template like this with i18n hooks where articles (like FAQ, ES6) would remain markdown. |
Adds i18n footer links, merges against #257 not master
Notes:
中文
for this in action. (Shows其他语言
instead ofLanguages
.)