Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Add pack and dist tasks #17

Merged
merged 2 commits into from
Jul 5, 2016
Merged

Add pack and dist tasks #17

merged 2 commits into from
Jul 5, 2016

Conversation

develar
Copy link
Contributor

@develar develar commented Jul 1, 2016

Icons are not added, I don't have assets (please see step 3).

During test, I have discovered issue — NPE if no installed node.

And currently, packed app cannot find installed node on MacOS because PATH is completely different for app (it is not the same as for CLI app). I will file issue about it. On Linux and Windows installed note detected correctly (yeah, MacOS :().

  • npm run pack will create packed app for current platform and arch.
  • npm run dist will pack app into distributable format for current platform and arch (e.g. DMG).
  • To explicitly set arch or platform: npm run dist -- -l (after -- any electron-builder args, here -l means build for Linux)
  • Please see Multi Platform Build. As there are no native deps — on MacOS you can build for any platform.

@develar
Copy link
Contributor Author

develar commented Jul 1, 2016

Please note — if in the future some files will be added into the project, which should not be packed into the production app, files must be used to ignore it, because you don't use two-package project structure.

@develar
Copy link
Contributor Author

develar commented Jul 1, 2016

I recommend use AppImage to distribute app for Linux, electron-builder will support AppImage target soon (I will open new PR).

@@ -1 +1,3 @@
node_modules
.idea/

This comment was marked as off-topic.

This comment was marked as off-topic.

@develar
Copy link
Contributor Author

develar commented Jul 4, 2016

Current name in the package.json is installer. electron-builder uses name as an application name.

So, installer should be changed to NodeJsInstaller.

And productName set to Node.js Installer.

If you don't mind, I can fix it as a part of this pull request.

@mikeal mikeal merged commit 27b28cc into nodejs:master Jul 5, 2016
@develar develar mentioned this pull request Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants