-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Test 250+ popular npm packages #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
We're not adding this to CI yet? We can just comment out the packages that don't work for now.
Aside from these popular npm packages, could we also test against some of the popular web frameworks? express
, fastify
, hapi
, connect
, sveltekit
, nextjs
, gatsby
, remix
. These are the most common places where users will use APM instrumentation, so I think it's important we catch any issues asap.
This can be added to CI, but likely not for every Node version that gets tested because some of these libs won't support such a wide range. These tests with then potentially break often as the versions aren't pinned and they will update their supported node versions. Maybe it's better the check in the
Yeah it's certainly worth adding more to this list. Initially this was to find potential gaps in the existing unit tests. If we pin the versions in a |
I've now added this to CI testing and you can see it running in my fork. |
Co-authored-by: James Sumners <[email protected]>
Adds a script that tests 250+ of the most popular npm packages. It compares the exports without and with the loader hook and fails if they don't match. It also fails if errors are thrown with the loader hook in use.