Generic method #145
Generic method #145
Conversation
…in HTTP version <= 1.0
…in HTTP version <= 1.0
|
I'm having some trouble fixing this one. The parser runs out of data before it actually finds anything invalid. At http_parser.c:1819, the default behaviour seems to be to assume that the request was valid. Mind taking a peek? |
|
I think adding a bit to http_parser indicating whether, given the current state, the request/response is valid if parsing were to stop immediately is a good solution. Any thoughts before I code it up later today? |
| if (ch == 'E') { | ||
| parser->method = HTTP_HEAD; | ||
| } else { | ||
| parser->type = HTTP_REQUEST; | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Reverted a simple test to succeed even though the result is invalid, because there are other more important things that need doing in this patch (like getting it to actually work)
|
Any update on accepting this? I really need support for custom methods but I'd rather not use a fork. |
|
@udp The patch still doesn't quite work iirc. Want me to pick it back up? |
|
That'd be great if you could. I don't mind doing some testing. |
|
alright, I'll get to it later today. On Tue, Aug 20, 2013 at 6:40 AM, James McLaughlin
|
|
@cmr to achieve full-spec CalDAV support for our project, mikedeboer/jsDAV, this'd be awesome to have! I'm guessing more and more ppl will stumble upon this sooner or later, but you'll be my hero to start with ;) |
|
I'm no longer interested in working on this. Sorry! |
Should close up #92 and pave the way for nodejs/node-v0.x-archive#3192. Currently depends on #144 or #106 being merged, because I wasn't paying attention and I don't know how to rebase it. Tests pass, but I'm still not confident in the patch quality. Review desired.