Release please config updates #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Mar 9, 2024
| @@ -7,8 +7,8 @@ name: release-please | |||
| jobs: | |||
| release-please: | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| contents: write | |||
| pull-requests: write | |||
| steps: | |||
| - uses: google-github-actions/release-please-action@v4 | |||
There was a problem hiding this comment.
Suggested change
| - uses: google-github-actions/release-please-action@v4 | |
| - uses: google-github-actions/release-please-action@v4 | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} |
IIRC, I set the token so that the release PR triggers CI workflows.
There was a problem hiding this comment.
Yes I have seen this be an issue before. I thought that secrets.GITHUB_TOKEN was the default token so it wouldn't trigger CI workflows, and it would need to pass in a different PAT for that to work.
If this is an issue we can try adding back the token.
There was a problem hiding this comment.
You're right. Workflows didn't run for #218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes the issues with the
release-pleaseworkflow failing after #225.It matches mostly what we have in https://github.com/nodejs/node-gyp