Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action defined in binding.gyp results misconfigured file path in generated vcxproj file #120

Closed
lkallas opened this issue Aug 16, 2021 · 1 comment · Fixed by #121
Closed

Action defined in binding.gyp results misconfigured file path in generated vcxproj file #120

lkallas opened this issue Aug 16, 2021 · 1 comment · Fixed by #121

Comments

@lkallas
Copy link

lkallas commented Aug 16, 2021 •
edited
Loading

Linking to another issue where gyp-next is used: nodejs/node-gyp#2485

But the problem is somewhere in the file path generation inside this repo.
@lkallas
Copy link
Author

lkallas commented Aug 18, 2021

The culprit has been found: nodejs/node-gyp#2485 (comment)

targos added a commit to targos/node-gyp that referenced this issue Aug 22, 2021
@targos
fix(msvs): fix paths again in action command arguments
73e405c 
This is a revert of nodejs/gyp-next#84
with a change to the _FixPath function allowing to change the
separator used.

Fixes: nodejs/gyp-next#120
Fixes: nodejs#2485
@targos targos mentioned this issue Aug 22, 2021
Merged
gengjiawen pushed a commit that referenced this issue Aug 22, 2021
@targos
fix(msvs): fix paths again in action command arguments (#121)
7159dfb 
* fix(msvs): fix paths again in action command arguments

This is a revert of #84
with a change to the _FixPath function allowing to change the
separator used.

Fixes: #120
Fixes: nodejs/node-gyp#2485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(msvs): fix paths again in action command arguments targos/gyp-next
1 participant
@lkallas