Remove unused attempt backport script #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a very neat part of the bot at one point, but ended up creating
some noise and got disabled.
It used to try backport of patches from created & updated PRs against
the `${version}.x-staging`s and as a result, added
`lts-watch-v${version}.x` or `dont-land-on-v${version}.x` when
applicable.
When it was operationale, it tried to apply patches against Node.js
versions: 4, 6 and 7. Those version are all end-of-life now.
For the bot to try backport of patches for newer versions of Node.js,
those versions would have to be added explicitly in the bot' source code.
That has obviously not happened, assuming the reason being it wasn't
as helpful afterall.
phillipj
force-pushed
the
remove-attempt-backport
branch
from
d1d8a30
to
a82bc8d
Compare
|
I'd completely forgotten we'd tried this before. Not sure if the other current members of @nodejs/releasers are aware of this either/think this would be useful to resurrect in an updated form (maybe instead of I have a vague recollection that @codebytere may have mentioned that Electron has a bot that does something similar? |
|
@nodejs/releasers you think it would be useful this resurrect this, ref @richardlau's comment above? If not, I'd really appreciate if we could sunset this code for now. We can always dig it back up again later if needed.. |
|
Since no objections were made, I'm merging this to remove this unused part of the source code for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a very neat part of the bot at one point (#77), but ended up creating some noise and parts got disabled (#118).
It used to try backport of patches from created & updated PRs against the
${version}.x-stagingbranches and as a result, addedlts-watch-v${version}.xordont-land-on-v${version}.xwhen applicable.When it was operational, it tried to apply PR patches against Node.js versions: 4, 6 and 7. Those version are all end-of-life now.
For the bot to try backport of patches for newer versions of Node.js, those versions would have to be added explicitly in the bot' source code. That has obviously not happened, assuming the reason being it wasn't as helpful afterall.