Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable Travis CI for i18n repo #171

Merged
merged 1 commit into from
May 31, 2018

Conversation

zeke
Copy link
Contributor

@zeke zeke commented May 15, 2018

Following steps outline by @rvagg in nodejs/build#1221:

It goes something like this:

  1. Add a webhook in your repo pointing to http://github-bot.nodejs.org:3333/hooks/github for pull requests and pushes, but you'll need the secret for that, I or @joyeecheung could do that or you could give @phillipj admin access to the repo and he could.
  2. Get a PR into github-bot to add your repo to the list.
  3. Profit .. ?

@phillipj I've added you as an admin on the i18n repo. If you're able to add the webhook, it would be much appreciated! Here's the URL: https://github.com/nodejs/i18n/settings/hooks/new

Resolves nodejs/build#1221 and nodejs/i18n#58

maddhruv

This comment was marked as off-topic.

@maclover7 maclover7 requested a review from rvagg May 15, 2018 19:39
joyeecheung

This comment was marked as off-topic.

@joyeecheung
Copy link
Member

@zeke Did this repo previously have Travis enabled? Or is it just a repo created within the nodejs organization? If it's a new repo (not transferred into the organization with previous Travis integration) that process does not actually work - since there is no way that we can inform Travis about the existence of the repo without giving it read access to our organization which is currently not allowed.

@joyeecheung
Copy link
Member

joyeecheung commented May 16, 2018

(By the way all of the dances could be rendered unnecessary if we just allow Travis to read organization...which needs a separate issue to discuss)

@zeke
Copy link
Contributor Author

zeke commented May 16, 2018

🤔 Maybe I should transfer the repo to another owner, set up Travis, then transfer it back?

@phillipj
Copy link
Member

This is now live in production 🚀

@zeke zeke deleted the enable-travis-for-i18n-repo branch May 31, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants