Add alpine to multi-arch support #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run |
|
Also, please update https://github.com/nodejs/docker-node/blob/master/4.8/architectures as well |
|
Just pushed the 4.8 update (didn't see that file). Here's the output from |
|
@tianon Could you please verify that the output above matches what's expected? 🙂 Diff vs docker-library/official-images#3655 diff --git i/library/node w/library/node
index a7ac2d7..91037f1 100644
--- i/library/node
+++ w/library/node
@@ -10,7 +9,7 @@ GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0
Tags: 9.0.0-alpine, 9.0-alpine, 9-alpine, alpine
-Architectures: amd64
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0/alpine
@@ -40,7 +39,7 @@ GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9
Tags: 8.9.0-alpine, 8.9-alpine, 8-alpine, carbon-alpine
-Architectures: amd64
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9/alpine
@@ -70,7 +69,7 @@ GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
Directory: 6.11
Tags: 6.11.5-alpine, 6.11-alpine, 6-alpine, boron-alpine
-Architectures: amd64
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
Directory: 6.11/alpine
@@ -96,11 +95,11 @@ Directory: 6.11/wheezy
Tags: 4.8.5, 4.8, 4, argon
Architectures: amd64, ppc64le, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+GitCommit: 0954065aee66693935d3afb0b28d47bd96266301
Directory: 4.8
Tags: 4.8.5-alpine, 4.8-alpine, 4-alpine, argon-alpine
-Architectures: amd64
+Architectures: amd64, ppc64le, arm64v8, arm32v7
GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
Directory: 4.8/alpine |
|
Yeah, just a couple notes:
|
|
Ok. I'll go ahead and make custom |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I think this now covers the feedback. Could you generate a new stackbrew for comparison? 🙂 |
|
Sure thing! Here it is... |
|
LGTM 👍 |
diff --git i/library/node w/library/node
index d58ad4e..6b8ad1f 100644
--- i/library/node
+++ w/library/node
@@ -10,7 +10,7 @@ GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0
Tags: 9.0.0-alpine, 9.0-alpine, 9-alpine, alpine
-Architectures: amd64
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6
GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0/alpine
@@ -40,7 +40,7 @@ GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9
Tags: 8.9.0-alpine, 8.9-alpine, 8-alpine, carbon-alpine
-Architectures: amd64
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6
GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9/alpine
@@ -66,7 +66,7 @@ Directory: 8.9/wheezy
Tags: 6.11.5, 6.11, 6, boron
Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+GitCommit: d5fae1082f7d7d46f04a156e45ba8cb809c915da
Directory: 6.11
Tags: 6.11.5-alpine, 6.11-alpine, 6-alpine, boron-alpine
@@ -96,7 +96,7 @@ Directory: 6.11/wheezy
Tags: 4.8.5, 4.8, 4, argon
Architectures: amd64, ppc64le, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+GitCommit: d5fae1082f7d7d46f04a156e45ba8cb809c915da
Directory: 4.8
Tags: 4.8.5-alpine, 4.8-alpine, 4-alpine, argon-alpineSo diff is that node-alpine@8 and node-alpine@9 gets builds for |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #568