-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yarn to 1.0.2 for Node 8.5 #525
Conversation
I can confirm that the update from yarn 0.27.5 (2924f14) broke our builds on node 8.5 but that yarn 1.0.2 does not have the corresponded bug. Requesting this gets merged quickly 👍 |
@nodejs/docker What should be done here? Pretty bad bug |
I'm torn. If this was the only change in Yarn 1.0.2 I'd say let's make a policy exception and upgrade it. But looking at the commit log there are 22 total commits between 1.0.1 and 1.0.2 so this is not a trivial/risk-free upgrade. |
Full diff: yarnpkg/yarn@v1.0.1...v1.0.2 |
I think we should merge it, the other changes aren't too crazy IMO, and the bug is really bad. |
Ok, in this case I agree. Does anyone else have objections? |
I'm looking through the commits for yarn 1.0.1 to 1.0.2 now |
Thanks all for pushing this exception though. Builds are humming along again 😀 |
This includes a particularly critical bug fix for private packages: yarnpkg/yarn#4422