Generate 'Architectures' information #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The output of generate-stackbrew-library.sh would be: |
|
@tianon Can you help to verify the output? and also help to review my change. Thanks. |
|
(Also worth noting that Alpine can't officially be made multiarch until gliderlabs/docker-alpine#304 is resolved. 👍) |
|
There is no wheezy here: https://hub.docker.com/r/ppc64le/buildpack-deps/ . So in my previous PR, I didn't add wheezy variant for ppc64le. :-) Thanks! |
|
Ahhh, right, wheezy+ppc64le is no longer supported (given the limited
Wheezy LTS resources).
|
|
For alpine, only amd64 supports alpine now. ppc64le could not support alpine until a fix get into v8. Based on your suggestion. I won't add any architecture for the alpine except amd64 if I need to add more architecture support in the future. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Enhance the `generate-stackbrew-library.sh` to generate `Architectures` information. Signed-off-by: Yihong Wang <[email protected]>
yhwang
force-pushed
the
add-architecture-to-stackbrew
branch
from
1afed76 to
bb2de80
Compare
|
Thanks @SimenB, @tianon and @Starefossen force push again now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the
generate-stackbrew-library.shto generateArchitecturesinformation.
Signed-off-by: Yihong Wang [email protected]