Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker-entrypoint.sh file handling, closes #1456 #1579

Merged
merged 4 commits into from
Oct 22, 2021

Commits on Oct 17, 2021

  1. fix: docker-entrypoint.sh file handling, closes nodejs#1456

    The docker-entrypoint.sh script added in
    nodejs#1039 is intended to run the
    supplied command with "node" if it contains a "-" or doesn't correspond
    to a system command. In Alpine, this doesn't work if the supplied
    command corresponds to a regular, non-executable JS file.
    
    The root issue is a bug in ash/dash: its implementation of "command -v"
    incorrectly outputs the supplied command_name even for non-executable
    files. This is a violation of the POSIX standard and has been reported
    to the Debian team in
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874264, though there's
    been no activity in several years.
    
    As a workaround, this adds an additional check to docker-entrypoint.sh
    for regular files that aren't marked as executable.
    MasonM committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    3101ce6 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Add regression test

    MasonM committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    f89451f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc060bd View commit details
    Browse the repository at this point in the history
  3. Update entrypoints for Node 17

    MasonM committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    be42a31 View commit details
    Browse the repository at this point in the history