Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand and organize repo #47

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Expand and organize repo #47

merged 1 commit into from
Jun 9, 2016

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Apr 18, 2016

This is to facilitate transition to a "Diagnostics WG" and to group content by domain. Please review and consider what changes to proposed domains might be needed, and whether to go forward with this transition.

It may be easier to review in integrated form at my fork.

Diagnostic capabilities and tools for Node are in great demand and many of the facilities have overlapping capabilities and consumers, so it seems best to gather and move this all forward in concert.

- [Chrome Debugging Protocol](https://chromedevtools.github.io/debugger-protocol-viewer/)
- [V8 Debugging Protocol](https://github.com/v8/v8/wiki/Debugging-Protocol)

Node currently relies on V8's internal Debug API and associated commands and events. The Debug API is published at [v8/include/v8-debug.h](https://gihtub.com/v8/v8/blob/master/include/v8-debug.h), and the message protocol is documented in prose in [the V8 wiki](https://github.com/v8/v8/wiki/Debugging-Protocol) and in code in [v8/src/debug/debug.js#L2341-2372](https://github.com/v8/v8/blob/master/src/debug/debug.js#L2341-L2372).

This comment was marked as off-topic.

This comment was marked as off-topic.

@joshgav joshgav force-pushed the foundation branch 2 times, most recently from 301a507 to 330b971 Compare April 19, 2016 22:53
Node uses `DefaultPlatform` from `v8:src/libplatform/default-platform.h` which currently simply returns 0.
A simplistic implementation which logs all trace events to stdout illustrates the basics:

```cpp

This comment was marked as off-topic.

This comment was marked as off-topic.

@bnoordhuis
Copy link
Member

The point about the v8 module still appears to be unaddressed.

* [LTTng](http://lttng.org/)
Linux only.
Some info on using LTTng with Node.js are available in the presentations
[Tracing Node on Linux with LTTNG](http://nearform.github.io/tracing-node-lttng-nodejsdublin/)

This comment was marked as off-topic.

@pmuellr
Copy link
Contributor

pmuellr commented Jun 8, 2016

LGTM

Add additional top level to repo with subfolders for diagnostic domains.
Add initial README.md for each domain.
Add some initial docs and samples for domains beyond tracing.
Move and minor cleanup of AsyncWrap docs and background info on
TRACE_EVENT.
@joshgav joshgav merged commit ab45c0e into nodejs:master Jun 9, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Jun 9, 2016

Squashed, updated commit message, and fast-forward merged. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants