chore(ci): better check for Nocks changes #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no changes, asking Git to compare the db file directly will always report change even though the actual data stored is the same. Instead, we can compare a SQL dump to detect actual changes.
arcanis
approved these changes
Jun 6, 2024
Comment on lines
+55
to
+56
| cp tests/nocks.db tests/nocks.db.new | ||
| git checkout HEAD -- tests/nocks.db |
There was a problem hiding this comment.
nit: Rather than the cp, you could use git show to dump the old content in a /tmp file without mutating the real nocks.db.
There was a problem hiding this comment.
I've considered it, and as I was not sure what would be the behavior of git show with binary files, I decided to do that cp dance instead. I don't feel strongly either way, happy to change it if you think it's better
There was a problem hiding this comment.
I'd expect it to be possible but I can't find the right syntax locally (I get no output), so feel free to merge as-is.
merceyz
reviewed
Jun 6, 2024
Co-authored-by: Kristoffer K. <[email protected]>
|
I confirmed it worked with https://github.com/nodejs/corepack/actions/runs/9400530569/job/25890336262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no changes, asking Git to compare the db file directly will always report change even though the actual data stored is the same. Instead, we can compare a SQL dump to detect actual changes.